Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AdiFormat.cpp #556

Closed
wants to merge 1 commit into from
Closed

Conversation

aa5sh
Copy link

@aa5sh aa5sh commented Dec 19, 2024

Removed the data type that was being added on a couple fields which were not handled properly on some imports.

Removed the data type that was being added on a couple fields which were not handled properly on some imports.
@foldynl
Copy link
Owner

foldynl commented Dec 20, 2024

Thanks for the PR. It's a lesson for me too, because we were both doing the same thing. Unfortunately, I have the changes locally so you didn't really know I was working on it. We need to coordinate it better. Do you have access to my project? https://github.com/users/foldynl/projects/12

Usually when I'm working on something I mark it as In-Progress.

@aa5sh
Copy link
Author

aa5sh commented Dec 20, 2024

Yeah I have seen your project previously. I should have said something as well. I will try and do better. I guess when I asked I had already looked and felt like it was a pretty simple thing and could knock it out quickly, but should have said that. I do appreciate your patience with me. I've always worked on things on my own so I am learning a lot through this process.

@foldynl
Copy link
Owner

foldynl commented Dec 21, 2024

Yes, it’s a new situation on both sides. It’s also complicated because it’s not just about considering new things, but ensuring that everything makes sense as a whole. I’m not talking about this PR, as it’s easy change. However, I deeply appreciate that there are people who actively contribute to the source code.

@foldynl
Copy link
Owner

foldynl commented Jan 11, 2025

v0.41 includes the PR

@foldynl foldynl closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - branch: testing_0.41
Development

Successfully merging this pull request may close these issues.

2 participants