-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detailed information about the compressed chunks #273
Conversation
Thanks for the review. By the end of the week I should be able to find some time to address the points raised. |
b4e607b
to
7acdd94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's close, just left some minor comments
Add a new `inspect-chunks` command that can provide additional information about the chunks in an index, including their compressed size (if a local store is provided). One use case is for the clients to download the server's inspect-chunks JSON and feed it into `desync info`, to calculate the precise download size of an update. Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
7acdd94
to
ba044f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Would it be worth adding an example to the README for this?
list-chunks
has now a new--detailed
option that allows to print additional information about the chunks, including their compressed size (if a local store is provided).One use case is for the clients to download the server's list-chunks JSON and feed it into
desync info
, to calculate the precise download size of an update.Addresses #270