check for win desktop app #2629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
found about this check in this |
vitaut
requested changes
Dec 3, 2021
| @@ -878,7 +878,7 @@ template <typename T> | |||
| struct has_member_data_tm_gmtoff<T, void_t<decltype(T::tm_gmtoff)>> | |||
| : std::true_type {}; | |||
|
|
|||
| #if defined(_WIN32) | |||
| #if defined(_WIN32) && (!defined(WINAPI_FAMILY) || (WINAPI_FAMILY == WINAPI_FAMILY_DESKTOP_APP)) | |||
There was a problem hiding this comment.
Let's merge tzset_once into format_utc_offset_impl to avoid repeating the check and since it's only used there.
There was a problem hiding this comment.
@vitaut, after the proposed merge the _tzset function will be called multiple times. Once for each tm_writer template instantiation.
It won't throw an error. But there may be a slowdown if present many tm_writer template instantiation with differents args.
There was a problem hiding this comment.
OK, let's keep this function but introduce a macro FMT_USE_TZSET instead to avoid repetition.
|
Closing in favor of #2633. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this #2628
this should checks for Windows desktop app, and disable for UWP, wich dont support
_tzset