small changes to reduce clang-9 warnings #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Aug 8, 2020
include/fmt/format.h
Outdated
| using iterator = remove_reference_t<decltype(reserve(out, 0))>; | ||
| using out_iterator = remove_reference_t<decltype(reserve(out, 0))>; |
There was a problem hiding this comment.
This can be removed completely.
There was a problem hiding this comment.
Is addressed with 412a658.
include/fmt/format.h
Outdated
| @@ -1593,7 +1593,7 @@ template <typename OutputIt, typename Char, typename UInt> struct int_writer { | |||
| format_decimal(digits, abs_value, num_digits); | |||
| basic_memory_buffer<Char> buffer; | |||
| size += prefix_size; | |||
| buffer.resize(size); | |||
| buffer.resize(to_unsigned(size)); | |||
There was a problem hiding this comment.
I suggest storing to_unsigned(size) in a variable (usize?) to avoid copy-pasta.
There was a problem hiding this comment.
Is adressed with e6159ed.
d44ba72 to
3b75c41
Compare
…e-declaration (prevents shadow-waringing in clang)
…signed to prevent 'implicit conversion changes signedness'-warnings in clang.
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Aug 18, 2020
Summary: Add PRs [#1808](fmtlib/fmt#1808), [#1812](fmtlib/fmt#1812), [#1816](fmtlib/fmt#1816), [#1818](fmtlib/fmt#1818) to improve cross-platform compatibility. Reviewed By: stepancheg Differential Revision: D23154350 fbshipit-source-id: 42f3781f70d376e1da2bcf34cb89a56f431371e4
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: Add PRs [#1808](fmtlib/fmt#1808), [#1812](fmtlib/fmt#1812), [#1816](fmtlib/fmt#1816), [#1818](fmtlib/fmt#1818) to improve cross-platform compatibility. Reviewed By: stepancheg Differential Revision: D23154350 fbshipit-source-id: 42f3781f70d376e1da2bcf34cb89a56f431371e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.