Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding convenience append(range) #1806

Closed
wants to merge 2 commits into from
Closed

Adding convenience append(range) #1806

wants to merge 2 commits into from

Conversation

brevzin
Copy link
Contributor

@brevzin brevzin commented Aug 7, 2020

Just a convenience overload of append() that can be invoked with contiguous ranges (notably string_views).

@vitaut
Copy link
Contributor

vitaut commented Aug 7, 2020

Thanks for the PR. Looks good but I suggest moving append to basic_memory_buffer because it's the only one available to users.

@vitaut
Copy link
Contributor

vitaut commented Aug 8, 2020

Merged in d0dd678.

@vitaut vitaut closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brevzin @vitaut