Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conflict with CoreServices.h under Mac OSX #350

Closed
gabime opened this issue Jul 4, 2016 · 2 comments
Closed

conflict with CoreServices.h under Mac OSX #350

gabime opened this issue Jul 4, 2016 · 2 comments

Comments

@gabime
Copy link
Contributor

gabime commented Jul 4, 2016

As reported here by spdlog users
@vitaut
Copy link
Contributor

vitaut commented Jul 12, 2016

Thanks for the bug report. I've localized the problem to the check macro defined in AssertMacros.h and will fix it shortly.

vitaut added a commit that referenced this issue Jul 12, 2016
@vitaut
check -> const_check to avoid a conflict with AssertMacros.h (#350)
8631694
@vitaut
Copy link
Contributor

vitaut commented Jul 12, 2016

Fixed in 8631694.

@vitaut vitaut closed this as completed Jul 12, 2016
@vitaut vitaut mentioned this issue Sep 9, 2016
Closed
foonathan pushed a commit that referenced this issue Oct 23, 2016
@vitaut @foonathan
check -> const_check to avoid a conflict with AssertMacros.h (#350)
3f778b2 
(cherry picked from commit 8631694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @gabime