Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not making FMT_USE_USER_DEFINED_LITERALS enabled by default #1148

Closed
merryhime opened this issue May 7, 2019 · 2 comments
Closed

Comments

@merryhime
Copy link

This produces a warning under -Wpendantic on GCC 9.1. The feature this depends upon is non-standard. Unfortunately ISO C++ did not adopt the use of string literal operator templates taking a character pack.

@merryhime merryhime changed the title Consider not making FMT_USE_USER_DEFINED_LITERALS Consider not making FMT_USE_USER_DEFINED_LITERALS enabled by default May 7, 2019
@vitaut
Copy link
Contributor

vitaut commented May 8, 2019

This is somewhat problematic because it will be a breaking change. However, you can disable user-defined literals by defining FMT_USE_USER_DEFINED_LITERALS to 0 when including {fmt}.

@vitaut
Copy link
Contributor

vitaut commented May 11, 2019

Actually disabling just UDL templates on GCC 9 by default should be fine because it will fallback to runtime checks. Done in a6e8ed1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants