Add args() accessor back to fmt::format_context

Add test that would fail to compile if you can't create a fmt::format_context from another fmt::format_context
fmtlib · Jan 15, 2025 · 30f8834 · 30f8834
1 parent 01914f0
commit 30f8834
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/include/fmt/base.h b/include/fmt/base.h
@@ -2656,6 +2656,7 @@ class context {
   FMT_CONSTEXPR auto arg_id(string_view name) const -> int {
     return args_.get_id(name);
   }
+  auto args() const -> const format_args& { return args_; }
 
   // Returns an iterator to the beginning of the output range.
   FMT_CONSTEXPR auto out() const -> iterator { return out_; }

diff --git a/test/compile-error-test/CMakeLists.txt b/test/compile-error-test/CMakeLists.txt
@@ -211,5 +211,12 @@ if (CMAKE_CXX_STANDARD GREATER_EQUAL 20)
   " ERROR)
 endif ()
 
+# Copying a format_context
+expect_compile(format-context-accessors "
+  auto copy_context = [](fmt::appender app, const fmt::format_context& ctx)
+    -> fmt::format_context
+  { return fmt::format_context(std::move(app), ctx.args(), ctx.locale()); };
+")
+
 # Run all tests
 run_tests()