-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write out full bgb data #711
Conversation
Question: do we write them out as differences as is the case now and as is done for all other such DROs, or do we change a) only these BGB guys b) all "derivatives" to be derivatives instead of differences? |
I am of the thought that it would be beneficial to actually switch over all derivatives in vlasiator to be proper derivatives - or, alternatively, rename the variables to differences. |
So do I add making all relevant DROs actual derivatives to this PR or shall I make a new one after merging this one? |
One thing at a time, I think :) But if that's what we want to do next, then indeed let's make this conform already to that style. |
Uh, I was only suggesting to make the DROs derivatives, not internally. |
Are these first commits going as far back as 2020 just github flukes? Or did I organise a git wreck again? |
It shows just 10 commits to me. |
Yes but the very first is from the stone age, and the later "merge dev into ykempf/dev" aren't particularly fresh either. |
All right here is the "lost" PR, I searched for "background" (or actually "ackgr") and didn't find it as it says bgb here... |
Merged into #786 |
Open for comments, seems to work as expected on my laptop. Quite a bit of duplicate code, I'm open for other ways of writing this...
In a second step we can discuss/implement a gridGlue patch that would do the vg versions of all these as well.