Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't have a fixed 100kb sizelimit for the xml footer anymore. #33

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ursg
Copy link
Contributor

@ursg ursg commented Aug 2, 2016

Instead, read in 4kb blocks in a loop until the end of file.

Instead, read in 4kb blocks in a loop until the end of file.
@ykempf
Copy link
Contributor

ykempf commented Aug 2, 2016

But that was a 1MB limit, not 100 kB...

@ursg
Copy link
Contributor Author

ursg commented Aug 2, 2016

Ah, well, anyway. The important part is that the limit is now longer there, isn't it?

Realistically, our xml footers will never exceed it anyway. But since it came up in a discussion, we might as well do this right.

@ykempf
Copy link
Contributor

ykempf commented Aug 2, 2016

Sure, fine with me if yo say it works in your tests.

@alhom
Copy link
Contributor

alhom commented Aug 5, 2024

PR necromancy! Thought this was a quick merge, but...

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/proj/mjalho/analysator/pyVlsv/vlsvreader.py", line 157, in __init__
    self.__read_xml_footer()
  File "/proj/mjalho/analysator/pyVlsv/vlsvreader.py", line 353, in __read_xml_footer
    xml_data += chunk
TypeError: can only concatenate str (not "bytes") to str

@alhom alhom merged commit 3133cd2 into fmihpc:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants