Update plot_ionosphere.py #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the reading of the ionospheric radius parameter and its reconstruction
|
A test with a previously failed file that does not have the ionosphere radius as a parameter in the VLSV file and a test with a file that does have the ionosphere radius parameter in the VLSV file. Analysator succeed to read and recalculate the ionosphere radius. |
alhom
reviewed
Jun 11, 2024
| ionosphere_radius = f.read_parameter("ionosphere_radius") | ||
| except: | ||
| # Recalculate the radius of the ionospheric grid | ||
| ionosphere_radius = np.max(np.linalg.norm(coords, axis=-1)) |
There was a problem hiding this comment.
So taking the max here assures that the argument to arccos can't accidentally get > 1. It's a nice safety.
alhom
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the reading of the ionospheric radius parameter and its reconstruction