Make objects for plate and well acquisitions #59
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 96.39% 98.74% +2.35%
==========================================
Files 27 42 +15
Lines 1884 2319 +435
Branches 0 232 +232
==========================================
+ Hits 1816 2290 +474
+ Misses 68 17 -51
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. |
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
3a3e709 to
a2fec4e
Compare
examples/test-matthieu.py
Outdated
| return tif.asarray(self.position.z) | ||
|
|
||
|
|
||
| class JohnsonWellAcquisition(WellAcquisition): |
There was a problem hiding this comment.
Nice! 🙂 We should call it VisiViewMultipositionAcquisition or similar and add it to the main code base.
There was a problem hiding this comment.
Definitely! But it needs a bit more love. Currently a bunch of things (e.g. spacing) is hard-coded and file-name parsing is also not very general.
These objects are aware of their source folder, and can provide references to files, positions, and channel metadata.
…X" (Y, Z) instead of stage position.
* Make sub-groups for projections. * Add CellVoyager example.
|
@imagejan I would squash-merge this into main and then continue with the renaming to faim-ipa. There are a few points where I am not sure if this will stay exactly as it is now, but it is hard to tell without testing it in the wild. I will add a couple issues to keep track of these points and then we can address them later. |
These objects are aware of their source folder, and can provide references to files, positions, and channel metadata.