Fix single field issue in _compute_z_spacing #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when processing an ImageXpress dataset with a single field per well, the
StackAcquisition._compute_z_spacingreturns an error like:The reason being that the
_compute_z_spacingfilters for unique fields, but that filtering fails when fields aren't set (=> are None in the fields table).A minor change to first check if there are any field of views before filtering the files list solves the problem and makes single field examples I have convertable. I don't have any tiny datasets to show the full workflow, but the newly added tests fail in the current faim-ipa version and pass with this minor adaptation.