Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageXpress: support time dimension #121

Merged
merged 3 commits into from
May 3, 2024
Merged

ImageXpress: support time dimension #121

merged 3 commits into from
May 3, 2024

Conversation

imagejan
Copy link
Member

@imagejan imagejan commented Apr 30, 2024

This adds an optional TimePoint_(?P<t>\d+) to the ImageXpress patterns, respects t when computing the tile position, and adds a t dimension to the well acquisition axes if applicable.

Remaining task:

  • add test dataset with multiple time points, and assert that well image shape corresponds to the reported axes.

@imagejan imagejan force-pushed the imagexpress-patterns branch 2 times, most recently from 83184eb to 6790844 Compare April 30, 2024 09:53
@imagejan imagejan force-pushed the imagexpress-patterns branch from 6790844 to 8439b9c Compare May 3, 2024 13:45
@imagejan imagejan force-pushed the imagexpress-patterns branch from 8439b9c to 6ee62a5 Compare May 3, 2024 13:50
@imagejan imagejan merged commit 0268686 into main May 3, 2024
13 checks passed
@imagejan imagejan deleted the imagexpress-patterns branch May 3, 2024 14:41
@imagejan
Copy link
Member Author

imagejan commented May 3, 2024

@fstur the changes in 241f723 (#121) should address your use cases, I suppose. They relax the regex patterns to allow for optional TimePoint_* subfolders (that are always created in newer versions of the ImageXpress acquisition software).

/cc @jluethi

@fstur
Copy link
Collaborator

fstur commented May 6, 2024

@imagejan thanks! I will have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants