Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

bug; aborted workflows bubble up the error and stay in running #149

Merged
merged 3 commits into from
Jun 9, 2020
Merged

bug; aborted workflows bubble up the error and stay in running #149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8af6fed
Fix aborted workflows
Jun 8, 2020
bba4104
Added more tests
Jun 9, 2020
5a1c90b
Workflow aborted msg
Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/controller/workflow/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,12 +423,12 @@ func (c *workflowExecutor) HandleAbortedWorkflow(ctx context.Context, w *v1alpha
if w.Status.FailedAttempts > maxRetries {
reason = fmt.Sprintf("max number of system retry attempts [%d/%d] exhausted - system failure.", w.Status.FailedAttempts, maxRetries)
err = errors.Errorf(errors.RuntimeExecutionError, w.GetID(), "max number of system retry attempts [%d/%d] exhausted. Last known status message: %v", w.Status.FailedAttempts, maxRetries, w.Status.Message)
}

// Best effort clean-up.
if err2 := c.cleanupRunningNodes(ctx, w, reason); err2 != nil {
logger.Errorf(ctx, "Failed to propagate Abort for workflow:%v. Error: %v", w.ExecutionID.WorkflowExecutionIdentifier, err2)
return err2
} else {
kumare3 marked this conversation as resolved.
Show resolved Hide resolved
// Best effort clean-up.
if err2 := c.cleanupRunningNodes(ctx, w, reason); err2 != nil {
logger.Errorf(ctx, "Failed to propagate Abort for workflow:%v. Error: %v", w.ExecutionID.WorkflowExecutionIdentifier, err2)
return err2
}
}

var status Status
Expand Down