This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Remove lyft api dependency and migrate to lyft->flyteorg #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
* Update task container generated name check (#155) * Update AWS SageMaker Operator (#156) * Update AWS SageMaker Operator Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Remove gogo and fix failing test.. Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Ping protobuf version to avoid unmarshaling breakage. Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip * restore makefile * replace Signed-off-by: Katrina Rogan <katrogan9@gmail.com> * replace Signed-off-by: Katrina Rogan <katrogan9@gmail.com> * restore Signed-off-by: Katrina Rogan <katrogan9@gmail.com> * no sidecar * updating resource Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * wip * Linter fix Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * wip * working * signoff Signed-off-by: Katrina Rogan <katrogan9@gmail.com> * sidecar working maybe Signed-off-by: Katrina Rogan <katrogan9@gmail.com> * refactor gone awry Signed-off-by: Katrina Rogan <katrogan9@gmail.com> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Katrina Rogan <katrogan9@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 60.01% 59.92% -0.09%
==========================================
Files 129 129
Lines 6955 6967 +12
==========================================
+ Hits 4174 4175 +1
- Misses 2361 2371 +10
- Partials 420 421 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
katrogan
approved these changes
Mar 8, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove dependency on Lyfts' kubeapi fork
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#377