Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dependencies in agent image #3008

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Unify dependencies in agent image #3008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a76e84e
Install all flyteagent image dependencies in a single command
eapolinario Dec 16, 2024
6849a10
test - Can I run docker commands in gh workflows?
eapolinario Dec 16, 2024
1cc49a1
Remove `-it` flag from `docker run`
eapolinario Dec 16, 2024
747b82a
Remove quick test after confirming that running `docker run --rm ghcr…
eapolinario Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pythonpublish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ jobs:
file: ./Dockerfile.agent
cache-from: type=gha
cache-to: type=gha,mode=max
- name: Confirm Agent can start
run: |
docker run --rm ghcr.io/${{ github.repository_owner }}/flyteagent:${{ github.sha }} pyflyte serve agent --port 8000 --timeout 1
- name: Push flyteagent-all Image to GitHub Registry
uses: docker/build-push-action@v2
with:
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile.agent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ ARG VERSION
RUN apt-get update && apt-get install build-essential -y \
&& pip install uv

RUN uv pip install --system prometheus-client grpcio-health-checking
RUN uv pip install --system --no-cache-dir -U flytekit==$VERSION \
flytekitplugins-airflow==$VERSION \
flytekitplugins-bigquery==$VERSION \
flytekitplugins-openai==$VERSION \
flytekitplugins-snowflake==$VERSION \
flytekitplugins-awssagemaker==$VERSION \
prometheus-client \
grpcio-health-checking \
&& apt-get clean autoclean \
&& apt-get autoremove --yes \
&& rm -rf /var/lib/{apt,dpkg,cache,log}/ \
Expand Down
Loading