Flyte CoPilot now available for all containers #64
Conversation
setup.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| __version__ = '0.17.30' | |||
| __version__ = '0.18.0' | |||
There was a problem hiding this comment.
It's not a breaking change... let's keep it at 17.
| __version__ = '0.18.0' | |
| __version__ = '0.17.31' |
There was a problem hiding this comment.
but, if you want to use data loading, you need a min version. That is why i was thinking of upping the minor?
There was a problem hiding this comment.
hmmm if you want to use data loading, you must be on 0.17.31+, same thing, right? we should really move to v1 :)
| // Flyte CoPilot, eliminates the needs of flytekit or sdk inside the container. Any inputs required by the users container are side-loaded in the input_path | ||
| // Any outputs generated by the user container - within output_path are automatically uploaded. | ||
| message DataLoadingConfig { | ||
| // MetadataFormat decides the encoding format in which the input metadata should be made available to the containers. |
There was a problem hiding this comment.
Sorry to be nitpicky, but I've read these comments three times now and I'm still confused. What is MetadataFormat? The comment says "... format in which the input metadata...". What is input metadata and how is it different than input? It sounds like it's the same thing. If it's an input, can we not just call it "Input"? Currently the situation makes it sound like: 1) there's input data; 2) there's metadata about that input; 3) the format of that metadata can be configured; but 4) the format of the input itself cannot be configured.
Sorry to be annoying but this is the IDL - names here stick around forever.
There was a problem hiding this comment.
i think we just need to write better documentation about metadata. as this is not really data in all cases.
TL;DR
Flyte CoPilot is available for all containers instead of a plugin.
Type
Are all requirements met?
Complete description
Refer to the issue and associated design
Tracking Issue
flyteorg/flyte#297
Follow-up issue
NA