This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
[MB-2105] Add list all to get state of the world for matching attributes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
previously approved these changes
Feb 11, 2020
| @@ -64,3 +64,23 @@ message MatchingAttributes { | |||
| ExecutionClusterLabel execution_cluster_label = 4; | |||
| } | |||
| } | |||
|
|
|||
| message MatchableResourceConfiguration { | |||
There was a problem hiding this comment.
nit: mind adding docs for the messages?
| } | ||
|
|
||
| message ListMatchableResourcesRequest { | ||
| string domain = 1; |
There was a problem hiding this comment.
we scope everything in the system by domain? but i can remove if you think it's not a great requirement!
|
|
||
| string project = 3; | ||
|
|
||
| string workflow = 4; |
There was a problem hiding this comment.
You would need Priority and Launch plan as well
There was a problem hiding this comment.
+1 for launch plan, thanks for the catch
as for priority, i'd rather the server render the resolved state of the world so the caller of this endpoint can see what the actual applied values are
| } | ||
|
|
||
| // Request all matching resource attributes. | ||
| message ListMatchableResourcesRequest { |
There was a problem hiding this comment.
Do you want to name this matchable ? or resource attribute.
|
ping @anandswaminathan |
|
+1 |
anandswaminathan
approved these changes
Feb 11, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.