This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Pass dynamic workflow closure in node execution events #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan
commented
Apr 13, 2021
| core.Identifier id = 1; | ||
|
|
||
| // Represents the compiled representation of the embedded dynamic workflow. | ||
| core.CompiledWorkflowClosure compiled_workflow = 2; |
There was a problem hiding this comment.
not sure if we want this, might just save and return the workflow id only
EngHabu
previously approved these changes
Apr 13, 2021
kumare3
reviewed
Apr 13, 2021
| core.Identifier id = 1; | ||
|
|
||
| // Represents the compiled representation of the embedded dynamic workflow. | ||
| core.CompiledWorkflowClosure compiled_workflow = 2; |
There was a problem hiding this comment.
is this what a regular workflow is also represented as?
There was a problem hiding this comment.
kumare3
previously approved these changes
Apr 13, 2021
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
EngHabu
previously approved these changes
Apr 13, 2021
| @@ -150,6 +151,18 @@ message TaskNodeMetadata { | |||
| core.CatalogCacheStatus cache_status = 1; | |||
| // This structure carries the catalog artifact information | |||
| core.CatalogMetadata catalog_key = 2; | |||
|
|
|||
| // In the case this task launched a dynamic workflow we capture its structure here. | |||
| DynamicWorkflowNodeMetadata dynamic_workflow_node_metadata = 16; | |||
There was a problem hiding this comment.
nit
Suggested change
| DynamicWorkflowNodeMetadata dynamic_workflow_node_metadata = 16; | |
| DynamicWorkflowNodeMetadata dynamic_workflow = 16; |
protos/flyteidl/event/event.proto
Outdated
| @@ -91,8 +92,19 @@ message TaskNodeMetadata { | |||
| core.CatalogCacheStatus cache_status = 1; | |||
| // This structure carries the catalog artifact information | |||
| core.CatalogMetadata catalog_key = 2; | |||
|
|
|||
| // In the case this task launched a dynamic workflow we capture its structure here. | |||
| DynamicWorkflowNodeMetadata dynamic_workflow_node_metadata = 16; | |||
There was a problem hiding this comment.
nit:
Suggested change
| DynamicWorkflowNodeMetadata dynamic_workflow_node_metadata = 16; | |
| DynamicWorkflowNodeMetadata dynamic_workflow = 16; |
There was a problem hiding this comment.
@EngHabu done (didn't use your suggestion b/c DCO :( )
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
EngHabu
approved these changes
Apr 13, 2021
milton0825
pushed a commit
to milton0825/flyteidl
that referenced
this pull request
Apr 14, 2021
Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
milton0825
pushed a commit
to milton0825/flyteidl
that referenced
this pull request
Apr 14, 2021
Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
EngHabu
pushed a commit
that referenced
this pull request
Apr 20, 2021
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
samhita-alla
added a commit
that referenced
this pull request
Apr 21, 2021
* dark theme updates (#134) Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * Added workflow for updating flyteidl version in all component (#132) * Added workflow for updating flyte comopnent version Signed-off-by: yuvraj <evalsocket@gmail.com> * Added a single workflow for release flyteidl Signed-off-by: yuvraj <evalsocket@gmail.com> * revert workflow changes Signed-off-by: yuvraj <evalsocket@gmail.com> * bug fix in ci (#135) Signed-off-by: yuvraj <evalsocket@gmail.com> * Enable flyteidl update version for all component (#136) * enable flyteidl update version for all component Signed-off-by: yuvraj <evalsocket@gmail.com> * Added more component Signed-off-by: yuvraj <evalsocket@gmail.com> * remove flytekit from component Signed-off-by: yuvraj <evalsocket@gmail.com> * Pass dynamic workflow closure in node execution events (#141) * Documentation for Datacatalog (#143) Datacatalog service documentation Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fix Datacatalog title.rst in docs (#145) * missing blank line in title.rst Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * generated docs Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Docs Staging Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com>
samhita-alla
added a commit
that referenced
this pull request
Apr 23, 2021
* dark theme updates (#134) Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * Added workflow for updating flyteidl version in all component (#132) * Added workflow for updating flyte comopnent version Signed-off-by: yuvraj <evalsocket@gmail.com> * Added a single workflow for release flyteidl Signed-off-by: yuvraj <evalsocket@gmail.com> * revert workflow changes Signed-off-by: yuvraj <evalsocket@gmail.com> * bug fix in ci (#135) Signed-off-by: yuvraj <evalsocket@gmail.com> * Enable flyteidl update version for all component (#136) * enable flyteidl update version for all component Signed-off-by: yuvraj <evalsocket@gmail.com> * Added more component Signed-off-by: yuvraj <evalsocket@gmail.com> * remove flytekit from component Signed-off-by: yuvraj <evalsocket@gmail.com> * Pass dynamic workflow closure in node execution events (#141) * Documentation for Datacatalog (#143) Datacatalog service documentation Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fix Datacatalog title.rst in docs (#145) * missing blank line in title.rst Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * generated docs Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Docs Staging Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * Docs Restructure Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com>
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
EngHabu
pushed a commit
that referenced
this pull request
Apr 26, 2021
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
samhita-alla
added a commit
that referenced
this pull request
Apr 29, 2021
* dark theme updates (#134) Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * Added workflow for updating flyteidl version in all component (#132) * Added workflow for updating flyte comopnent version Signed-off-by: yuvraj <evalsocket@gmail.com> * Added a single workflow for release flyteidl Signed-off-by: yuvraj <evalsocket@gmail.com> * revert workflow changes Signed-off-by: yuvraj <evalsocket@gmail.com> * bug fix in ci (#135) Signed-off-by: yuvraj <evalsocket@gmail.com> * Enable flyteidl update version for all component (#136) * enable flyteidl update version for all component Signed-off-by: yuvraj <evalsocket@gmail.com> * Added more component Signed-off-by: yuvraj <evalsocket@gmail.com> * remove flytekit from component Signed-off-by: yuvraj <evalsocket@gmail.com> * Pass dynamic workflow closure in node execution events (#141) * Documentation for Datacatalog (#143) Datacatalog service documentation Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fix Datacatalog title.rst in docs (#145) * missing blank line in title.rst Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * generated docs Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Docs Staging Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * Docs Restructure Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * updated main sidebar Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com>
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Pass dynamic workflow closure in node execution events and also serialize as part of NodeExecutions in flyteadmin.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyteconsole#295
Follow-up issue
NA