Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide archived workflows in Console #71

Merged
merged 3 commits into from
May 26, 2020
Merged

Conversation

schottra
Copy link
Contributor

NamedEntities can now have a state value indicating they are archived. The goal of this is to allow users to archive workflows so that they aren't cluttering up the UI. Supporting this in the UI is fairly trivial (update our list request to add a filter for only the active state).
I also added a test file for ProjectWorkflows and a test to assert that we are filtering to only active workflows and updated the yarn.lock file.

@schottra schottra requested review from BobNisco and podehnal May 21, 2020 19:47
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #71 into master will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   58.65%   59.13%   +0.48%     
==========================================
  Files         363      364       +1     
  Lines        5664     5673       +9     
  Branches      847      847              
==========================================
+ Hits         3322     3355      +33     
+ Misses       2342     2318      -24     
Impacted Files Coverage Δ
src/components/Project/ProjectWorkflows.tsx 100.00% <100.00%> (+33.33%) ⬆️
src/test/modelUtils.ts 100.00% <100.00%> (ø)
src/routes/routes.ts 47.72% <0.00%> (+2.27%) ⬆️
src/components/hooks/useNamedEntity.ts 55.55% <0.00%> (+14.81%) ⬆️
...components/Workflow/SearchableWorkflowNameList.tsx 93.33% <0.00%> (+40.00%) ⬆️
...rc/components/common/SearchableNamedEntityList.tsx 100.00% <0.00%> (+45.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d9b03...65a1d42. Read the comment docs.

@schottra schottra merged commit 23b6f5f into master May 26, 2020
@schottra schottra deleted the filter-archived-workflows branch May 26, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants