Sorting keys wherever we render inputs/outputs #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#98
Object.entries
andObject.keys
don't guarantee an ordering. This is normally not a problem, except we directly render the result of calling these functions on an input/output object to the screen.Since the API response also does not guarantee ordering, this can mean a re-ordering in the rendered content when we are polling for execution status and/or changing launch plan versions.
Consistency of display is preferred to optimal ordering of values, so for now we will sort the values lexicographically.
Object.entries
andObject.keys
and subsequently sorting the resulting arrays