New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth config examples #773

Closed

EngHabu wants to merge 74 commits into master from authentication

Contributor

EngHabu commented Feb 23, 2021 •

edited

Loading

Update documentation with steps on how to configure auth for a few popular services...

Contributor

kumare3 commented Feb 26, 2021

Probably want to update this for changes needed to propeller?

wild-endeavor previously approved these changes

View reviewed changes

EngHabu dismissed wild-endeavor’s stale review via

April 11, 2021 13:59

EngHabu mentioned this pull request

[Breaking] OAuth2 Authorization Server implementation, Separate OpenID and OAuth2 configs, OAuth2 Metadata over gRPC #minor flyteorg/flyteadmin#168

Merged

8 tasks

tnsetting reviewed

View reviewed changes

kustomize/base/single_cluster/headless/config/admin/server.yaml

+                        - all
+                userAuth:
+                  openId:
+                    baseUrl: https://accounts.google.com

Contributor

tnsetting Apr 22, 2021

One issue with the base url is that https://accounts.google.com/.well-known/oauth-authorization-server does not exist.

Contributor Author

EngHabu Apr 30, 2021

If you put https://accounts.google.com under appAuth -> baseUrl then it won't work because Google doesn't offer An authorization server for personal use.. (outside of GCP).

if you put it (as in this file) under userAuth -> openId -> baseUrl, we won't try to hit that well known url, we will, instead, hit https://accounts.google.com/.well-known/openid-configuration which is available...

EngHabu and others added 25 commits

April 30, 2021 16:59


          Fix push image condition (#767)

d1f6dc1

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add auth config examples

cc974e6

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          update

4ca3169

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update docs on configuring flyteadmin matchable attributes (#772)

71d177d

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Fix docs: Broken links etc (#771)

a89f8cf

* fix broken links

* Replace references

* Fix more issues

* Update rsts/faq/gcp.rst

Co-authored-by: Katrina Rogan <katrina@nuclyde.io>

* Update rsts/howto/flytecli.rst

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Update docs on configuring flyteadmin matchable attributes (#772)

Co-authored-by: Katrina Rogan <katrina@nuclyde.io>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Updating Getting started to use the single Image (#775)

ba7b78f

* Updating Getting started to use the single Image

* Updated

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update readme to have a getting started section (#777)

32a594b

* Readme updated

* Readme updated

* Updated

* changelog

* Meeting link updated

* updated

* Update README.md

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update rsts/community/index.rst

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update readme badges

20e9e46

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Default Grafana templates for various Flyte components using Promethe…

4260e6e

…us (#779)

- These dashboards as also published to grafana marketplace

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Docs Update: Extending flyte & deploying observability (#780)

cfe7784

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Fix issues with kustomize templates (#783)

2e28f1a

* Fix issues with kustomize templates

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* Use remote URL for contour-ingress-controller

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* fix

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* fix

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* Remove contour from test overlay

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Better index (#785)

2dc9086

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Consolidate meeting notes and demo signup sheet (#787)

307f31e

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add kubernetes dashboard to sandbox overlay (#789)

1d45286

* Add kubernetes dashboard to sandbox overlay

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* Remove task logs from headless kustomize module

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* Update first run doc to expose 30082 for kubernetes dashboard

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* use kubernetes-template-url for specifying log URL in sandbox overlay

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* Update flytepropeller to v0.6.1 to leverage `kubernetes-template-uri` config

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Sandbox diagram added to Documentation (#798)

55e3757

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Milestone v0.11 (#794)

42dde79

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          AWS EKS Illustration: Production single cluster mode (#799)

f91c267

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Create housekeeping_template.md (#804)

d3244f5

* Create housekeeping_template.md

* correct the label

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          create_node_execution_event was missing (#795)

7ded64d

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add a small bashrc to flyte sandbox (#811)

ac66683

Signed-off-by: wild-endeavor <wild-endeavor@users.noreply.github.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Allow K3s K8s Api Port to be overriden (#812)

993a907

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update first_run.rst (#821)

2228c76

Spelling, sentence rewording, "Flyte is read" and "Go ahead" moved to next line.
http://localhost:30081/console is a broken link.

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update Docs Copyright date (#830)

cc21097

Signed-off-by: v01dxyz <v01dxyz@users.noreply.github.com>

Co-authored-by: v01dxyz <v01dxyz@users.noreply.github.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update first_run.rst (#829)

489e182

Capitalize With

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update EKS Ingress and Instructions (#825)

1698f88

* Update EKS Ingress and Instructions

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Move alb ingress to addons

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Update k8s version used in KinD

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* delete unused file

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* PR Comments

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* comments

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

jeevb and others added 27 commits

April 30, 2021 16:59


          Add init container that will pre-create buckets in minio (#905)

b7776dd

* Add init container that will pre-create buckets in minio

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>

* move minio tag override to overlay

Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add LF AI & Data Logo to README (#902)

f7f8434

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Explaining the state machine used by FlytePropeller and Flyte (#903)

eca30b0

* Explaining the state machine used by FlytePropeller and Flyte

 - this document helps to explain the various states a workflow, node
and task transitions through.
 - TODO add a small table that helps users understand what a state in
the UI represents

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated docs (addressed comments)

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* comments addressed - image for nodes improved

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          updated headings

430e292

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          fix google url

b90b878

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update index.rst (#911)

19d3133

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

wip

bf2dbcf

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Break up Auth article

bf43edf

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          doc updates

bdd242a

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update docs

9e38bf9

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add github

16de21b

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Simplify setup

c2258fa

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update docs for migration to include Propeller's config

7cd7994

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Update versions

08a9dee

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Fix default eks storage config (#907)

0acbea4

* Fix default eks storage config

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* kustomize

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* bump

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Remove flyteadmin config options which now have defaults (#917)

e0dcb4d


          Contribution Guide (#922)

e17cfcc

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          explicitly grant flyteworkflow finalizer permissions to flytepropeller (

#930)

* explicitly grant flyteworkflow finalizer permissions to flytepropeller

Signed-off-by: akumor <akumor@gmail.com>

* add kustomize output after adding flyteworkflows/finalizers rbac

Signed-off-by: akumor <akumor@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Add dynamic running state to node state machine (#929)

9d171d3

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Updated Boilerplate Code (#932)

7525a31

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Added goreleaser for publishing menifest (#927)

673e300

* added goreleaser for publishing menifest

Signed-off-by: yuvraj <evalsocket@gmail.com>

* Rename release file name

Signed-off-by: yuvraj <evalsocket@gmail.com>

* Added script for artifacts

Signed-off-by: yuvraj <evalsocket@gmail.com>

* More changes

Signed-off-by: yuvraj <evalsocket@gmail.com>

* More changes

Signed-off-by: yuvraj <evalsocket@gmail.com>

* fix typo

Signed-off-by: yuvraj <evalsocket@gmail.com>

* minor changes

Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Added flytectl in sandbox (#952)

49e4fba

* Added sandbox changes for new release process

Signed-off-by: yuvraj <evalsocket@gmail.com>

* curl added in sandbox build image

Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Modify repo name in Makefile (#953)

6c25396

* Updated Boilerplate Code

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* modified export line

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Signed-off-by: Samhita Alla aallasamhita@gmail.com (#955)

870ac8f

Co-authored-by: Niels Bantilan niels.bantilan@gmail.com

Documentation revamp restructuring according to the RFC: https://docs.google.com/document/d/1Yp5cYujKT6UMv17Y6r1djMchaMZWAlPNUTZnbw1sZvc/edit#heading=h.vozt1qaes3ur

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          added tagline (#956)

7e81123

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          Fix broken Kustomize link in docs (#944)

b4a5199

Signed-off-by: Tom Forbes <tom@tomforb.es>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>


          update getting started guide (#958)

d451a01

since we're consolidating our docs, we want to use the getting
started example originally from flytesnacks. Here we're moving
it into the flyte repo since the flytesnacks example should be
the canonical getting started guide

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

EngHabu force-pushed the authentication branch from c26d025 to d451a01 Compare

May 1, 2021 00:05

EngHabu closed this

palchicz pushed a commit to palchicz/flyte that referenced this pull request


          Complex dataclass unit tests (flyteorg#773)

ec19076

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet