Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve field in execution metadata #6174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

troychiu
Copy link
Member

@troychiu troychiu commented Jan 16, 2025

What changes were proposed in this pull request?

Reserved a field in execution metadata.

Summary by Bito

This PR updates the execution metadata protobuf definition by reserving field numbers 19-20 and adding multiple new fields including notifications, labels, security context, and various configuration options. The changes maintain backward compatibility through proper field reservations and include updates to both Python and Go generated protobuf code.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

Signed-off-by: Troy Chiu <y.troychiu@gmail.com>
@flyte-bot
Copy link
Collaborator

flyte-bot commented Jan 16, 2025

Code Review Agent Run #132c49

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: b6460f9..b6460f9
    • flyteidl/gen/pb-go/flyteidl/admin/execution.pb.go
    • flyteidl/gen/pb_python/flyteidl/admin/execution_pb2.py
    • flyteidl/protos/flyteidl/admin/execution.proto
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Protocol Buffer Field Reservation

execution.pb.go - Reserved field 19-20 in execution metadata protobuf definition

Other Improvements - Protocol Buffer Field Reservation and Updates

execution.pb.go - Added new fields and updated execution metadata protobuf definition with reserved fields

Other Improvements - Protocol Buffer Field Management

execution.proto - Added field reservation (field 19) in ExecutionMetadata message

execution_pb2.py - Updated protobuf descriptor serialization offsets to reflect field reservation

execution.pb.go - Reserved field 19-20 in execution metadata protobuf definition

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.06%. Comparing base (c20cd47) to head (b6460f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6174   +/-   ##
=======================================
  Coverage   37.06%   37.06%           
=======================================
  Files        1318     1318           
  Lines      132638   132638           
=======================================
  Hits        49157    49157           
  Misses      79231    79231           
  Partials     4250     4250           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.33% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.85% <ø> (ø)
unittests-flytepropeller 42.69% <ø> (ø)
unittests-flytestdlib 55.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants