Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend Admin to use grpc message size #5628

Merged
merged 10 commits into from
Aug 2, 2024
11 changes: 11 additions & 0 deletions .github/actions/clear-action-cache/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: 'Clear action cache'
description: 'As suggested by GitHub to prevent low disk space: https://github.com/actions/runner-images/issues/2840#issuecomment-790492173'
runs:
using: 'composite'
steps:
- shell: bash
run: |
rm -rf /usr/share/dotnet
rm -rf /opt/ghc
rm -rf "/usr/local/share/boost"
rm -rf "$AGENT_TOOLSDIRECTORY"
6 changes: 4 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ jobs:
- name: Fetch flyte code
uses: actions/checkout@v4
with:
path: "${{ github.workspace }}/flyte"
path: flyte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs, the github workspace is implicit.

- name: 'Clear action cache'
uses: ./flyte/.github/actions/clear-action-cache
- name: Fetch flytekit code
uses: actions/checkout@v4
with:
repository: flyteorg/flytekit
path: "${{ github.workspace }}/flytekit"
path: flytekit
- uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
Expand Down
2 changes: 1 addition & 1 deletion flyteadmin/pkg/server/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
grpc.UnaryInterceptor(chainedUnaryInterceptors),
}
if cfg.GrpcConfig.MaxMessageSizeBytes > 0 {
serverOpts = append(serverOpts, grpc.MaxRecvMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes))
serverOpts = append(serverOpts, grpc.MaxRecvMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes), grpc.MaxSendMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes))

Check warning on line 122 in flyteadmin/pkg/server/service.go

View check run for this annotation

Codecov / codecov/patch

flyteadmin/pkg/server/service.go#L122

Added line #L122 was not covered by tests
}
serverOpts = append(serverOpts, opts...)
grpcServer := grpc.NewServer(serverOpts...)
Expand Down
Loading