Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] correctly set task execution phase for terminal array node #5136

Merged
merged 5 commits into from
Jan 13, 2025

update unit tests

8e4f4fa
Select commit
Loading
Failed to load commit list.
Merged

[Bug] correctly set task execution phase for terminal array node #5136

update unit tests
8e4f4fa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

37.02% (+0.00%) compared to b010747

View this Pull Request on Codecov

37.02% (+0.00%) compared to b010747

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.02%. Comparing base (b010747) to head (8e4f4fa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 40.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5136   +/-   ##
=======================================
  Coverage   37.02%   37.02%           
=======================================
  Files        1317     1317           
  Lines      132523   132544   +21     
=======================================
+ Hits        49066    49080   +14     
- Misses      79211    79218    +7     
  Partials     4246     4246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov