Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Trim execution error messages to avoid spamming downstream systems #334

Closed
1 of 13 tasks
EngHabu opened this issue May 30, 2020 · 0 comments
Closed
1 of 13 tasks

[Feature] Trim execution error messages to avoid spamming downstream systems #334

EngHabu opened this issue May 30, 2020 · 0 comments
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers

Comments

@EngHabu
Copy link
Contributor

EngHabu commented May 30, 2020

Motivation: Why do you think this is important?
Errors can be arbitrary long since they are written by containers/potentially 3rd party plugins. We should ensure the error message length will never be big enough to cause write failures to Etcd. or spam Admin DB with huge objects.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 30, 2020
@EngHabu EngHabu mentioned this issue May 30, 2020
Merged
8 tasks
@EngHabu EngHabu closed this as completed Jun 1, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@mayitbeegh
Switch to using encoder in pluginmachinery (flyteorg#334)
27f2f56 
Signed-off-by: Sean Lin <sean@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@kumare3 @jinserk
@samhita-alla @cosmicBboy
Single node GPU training example (flyteorg#333)
ff4e179 
* Single node GPU training example

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Minor fix related to tensorboard in PyTorch (flyteorg#334)

Signed-off-by: Jinserk Baik <823222+jinserk@users.noreply.github.com>

* updated pytorch training example

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* wandb integration, code lint, content

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* remove misplaced text

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* add pytorch in tests' manifest

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* changed pytorch to mnist

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* dockerfile

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* update link

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update deps

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

Co-authored-by: Jinserk Baik <823222+jinserk@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: cosmicBboy <niels.bantilan@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@jsonporter
Changed memo filter to scopedId from node.id (flyteorg#334)
831d738 
Signed-off-by: Jason Porter <jason@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@snyk-bot
fix: doc-requirements.txt to reduce vulnerabilities (flyteorg#334)
4596f5e 
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-LXML-2940874
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Validate multiple input values in map task (flyteorg#334)
e84d27a 
* validating multiple input values in map task and correctly populating for cache lookup

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests

Signed-off-by: Daniel Rammer <daniel@union.ai>

---------

Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@mayitbeegh
Switch to using encoder in pluginmachinery (flyteorg#334)
e00d3fd 
Signed-off-by: Sean Lin <sean@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Validate multiple input values in map task (flyteorg#334)
4f11527 
* validating multiple input values in map task and correctly populating for cache lookup

Signed-off-by: Daniel Rammer <daniel@union.ai>

* added unit tests

Signed-off-by: Daniel Rammer <daniel@union.ai>

---------

Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@snyk-bot
fix: doc-requirements.txt to reduce vulnerabilities (flyteorg#334)
c7e543a 
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-LXML-2940874
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@snyk-bot @austin362667
fix: doc-requirements.txt to reduce vulnerabilities (flyteorg#334)
5408044 
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-LXML-2940874
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@snyk-bot @robert-ulbrich-mercedes-benz
fix: doc-requirements.txt to reduce vulnerabilities (flyteorg#334)
9a25882 
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-LXML-2940874
troychiu pushed a commit that referenced this issue Jul 8, 2024
@thomasjpfan
Run rust formatting on all rust code and add check to CI (#334)
7cf7643 
## Overview
This PR adds a rust linter to the CI.

## Upstream Changes
- [ ] To be upstreamed to OSS

## Issue
We can not ignore generated files on the stable rust compiler: https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#ignore. I'm okay with running `cargo fmt --all` and just format everything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EngHabu