Skip to content

Commit

Permalink
fix error
Browse files Browse the repository at this point in the history
Signed-off-by: Nelson Chen <asd3431090@gmail.com>
  • Loading branch information
arbaobao committed Jan 15, 2025
1 parent 694ffc5 commit ce8aca8
Show file tree
Hide file tree
Showing 6 changed files with 88 additions and 1 deletion.
68 changes: 68 additions & 0 deletions flyteplugins/go/tasks/pluginmachinery/core/mocks/task_overrides.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ func dummyTaskExecutionMetadata(resources *v1.ResourceRequirements, extendedReso
to.On("GetResources").Return(resources)
to.On("GetExtendedResources").Return(extendedResources)
to.On("GetContainerImage").Return(containerImage)
to.On("GetAnnotations").Return(map[string]string{"annotation-1": "val1"})
to.On("GetLabels").Return(map[string]string{"label-1": "val1"})
taskExecutionMetadata.On("GetOverrides").Return(to)
taskExecutionMetadata.On("IsInterruptible").Return(true)
taskExecutionMetadata.OnGetPlatformResources().Return(&v1.ResourceRequirements{})
Expand Down
2 changes: 2 additions & 0 deletions flyteplugins/tests/end_to_end.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ func RunPluginEndToEndTest(t *testing.T, executor pluginCore.Plugin, template *i
})
overrides.OnGetExtendedResources().Return(&idlCore.ExtendedResources{})
overrides.OnGetContainerImage().Return("")
overrides.OnGetAnnotations().Return(map[string]string{})
overrides.OnGetLabels().Return(map[string]string{})

tMeta := &coreMocks.TaskExecutionMetadata{}
tMeta.OnGetTaskExecutionID().Return(tID)
Expand Down
2 changes: 1 addition & 1 deletion flytepropeller/pkg/apis/flyteworkflow/v1alpha1/iface.go
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ type ExecutableNode interface {
GetActiveDeadline() *time.Duration
IsInterruptible() *bool
GetName() string
GetContainerImage()
GetContainerImage() string
GetAnnotations() map[string]string
GetLabels() map[string]string
}
Expand Down

0 comments on commit ce8aca8

Please sign in to comment.