Skip to content

Commit

Permalink
Adds ARG to adjust local base image (#339)
Browse files Browse the repository at this point in the history
## Overview
The `Dockerfile` hardcodes `quay.io/pypa/manylinux2014_x86_64`, with this PR it can now be adjusted:

```
# macos development
docker image build --build-arg="MANYLINUX_BASE_IMAGE=quay.io/pypa/manylinux2014_aarch64" \
    -t fasttask-runner:0.0.11 .

docker image build --build-arg="MANYLINUX_BASE_IMAGE=quay.io/pypa/manylinux2014_x86_64" \
    -t fasttask-runner:0.0.11 .
```

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS
  • Loading branch information
thomasjpfan authored Jun 25, 2024
1 parent 7cf7643 commit c76fe66
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion fasttask/worker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
# If you are running with the cache run:
# docker builder prune --filter type=exec.cachemount

FROM quay.io/pypa/manylinux2014_x86_64 as build
# If your Flyte is running on aarch64 (Apple Silicon), run:
# docker image build \
# --build-arg="MANYLINUX_BASE_IMAGE=quay.io/pypa/manylinux2014_aarch64" \
# -t fasttask-runner:TAG .
ARG MANYLINUX_BASE_IMAGE=quay.io/pypa/manylinux2014_x86_64
FROM ${MANYLINUX_BASE_IMAGE} as build

RUN curl https://sh.rustup.rs -sSf | sh -s -- --profile=minimal -y
ENV PATH="/root/.cargo/bin:${PATH}"
Expand Down

0 comments on commit c76fe66

Please sign in to comment.