Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Update flux crds #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update flux crds #58

wants to merge 1 commit into from

Conversation

chanwit
Copy link
Contributor

@chanwit chanwit commented Sep 9, 2021

This PR is split from #57. It contains a change for updating CRDs to Flux2 v0.17.0.

@chanwit
Copy link
Contributor Author

chanwit commented Sep 9, 2021

@squaremo @jpellizzari PTAL

jpellizzari
jpellizzari reviewed Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRD change looks fine, but I'm not sure why the protobuf stuff needed to change.

@chanwit chanwit requested a review from jpellizzari September 9, 2021 19:02
jpellizzari
jpellizzari approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chanwit
Copy link
Contributor Author

chanwit commented Sep 10, 2021

@squaremo could you please take a look?

@chanwit
update Flux CRDs
3b1e0d6 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit chanwit requested a review from jpellizzari September 10, 2021 14:43
@stefanprodan
Copy link
Member

I think we should add the crds to .gitignore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanwit @stefanprodan @jpellizzari