Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Azure Blob support to BucketController #513

Closed
wants to merge 56 commits into from
Closed

Add native Azure Blob support to BucketController #513

Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
04219b8
Add native support to Azure Blob
laozc Dec 3, 2021
774cf9a
Remove calling deprecated MSI function
laozc Dec 3, 2021
e89ef08
Update CRD
laozc Dec 4, 2021
8e86b57
Introduce more explicit Condition types
hiddeco Jul 30, 2021
c50a170
Implement new runtime interfaces, prepare testenv
hiddeco Jul 30, 2021
65dd61e
Introduce `artifactSet` to replace `hasArtifactUpdated`
hiddeco Jul 30, 2021
c278501
source: Add `GetRequeueAfter`
darkowlzz Nov 24, 2021
2d88469
Use new events and metrics helpers in main.go
darkowlzz Nov 24, 2021
e7f0406
Move Artifact conditions to conditions
darkowlzz Nov 24, 2021
a722ec7
Add gomega matcher for artifact
darkowlzz Nov 25, 2021
0ae7758
Fixes PR comments
laozc Dec 7, 2021
f1302d8
bucket: Replace GetInterval() with GetRequeueAfter()
darkowlzz Nov 24, 2021
795b83d
Rewrite `BucketReconciler` to new standards
hiddeco Jul 31, 2021
f82a906
Consolidate condition types into `FetchFailed`
hiddeco Aug 9, 2021
6f34ea8
BucketReconciler: Add reconcileArtifact tests
darkowlzz Aug 9, 2021
317cd44
Add more reconcileMinioSource test cases
darkowlzz Nov 27, 2021
4814abc
Add bucket controller tests for reconcileGCPSource
darkowlzz Nov 29, 2021
625f850
bucket: Ignore patch error not found on delete
darkowlzz Dec 8, 2021
6931fed
Merge remote-tracking branch 'origin/reconcilers-dev-bucket' into azblob
laozc Dec 11, 2021
4dd7799
Update go.sum
laozc Dec 11, 2021
e9d5353
Introduce more explicit Condition types
hiddeco Jul 30, 2021
10a8cc4
Implement new runtime interfaces, prepare testenv
hiddeco Jul 30, 2021
c1668ef
Introduce `artifactSet` to replace `hasArtifactUpdated`
hiddeco Jul 30, 2021
e5806c3
source: Add `GetRequeueAfter`
darkowlzz Nov 24, 2021
adb131c
Use new events and metrics helpers in main.go
darkowlzz Nov 24, 2021
2b7a308
Move Artifact conditions to conditions
darkowlzz Nov 24, 2021
e82a472
Add gomega matcher for artifact
darkowlzz Nov 25, 2021
b65e9bf
Add internal packages error and result
darkowlzz Dec 19, 2021
a956216
bucket: Replace GetInterval() with GetRequeueAfter()
darkowlzz Nov 24, 2021
27455c4
Rewrite `BucketReconciler` to new standards
hiddeco Jul 31, 2021
009acb6
Consolidate condition types into `FetchFailed`
hiddeco Aug 9, 2021
421f50d
BucketReconciler: Add reconcileArtifact tests
darkowlzz Aug 9, 2021
066f74a
Add more reconcileMinioSource test cases
darkowlzz Nov 27, 2021
18fd284
Add bucket controller tests for reconcileGCPSource
darkowlzz Nov 29, 2021
bd0ee6e
bucket: Ignore patch error not found on delete
darkowlzz Dec 8, 2021
878856c
bucket: Add more reconciler design improvements
darkowlzz Dec 20, 2021
f912cbf
Merge remote-tracking branch 'origin/reconcilers-dev-bucket' into azblob
laozc Jan 6, 2022
c2793ef
Introduce more explicit Condition types
hiddeco Jul 30, 2021
d7e0faa
Implement new runtime interfaces, prepare testenv
hiddeco Jul 30, 2021
7d752b7
Introduce `artifactSet` to replace `hasArtifactUpdated`
hiddeco Jul 30, 2021
d9ad873
source: Add `GetRequeueAfter`
darkowlzz Nov 24, 2021
1c25c8c
Use new events and metrics helpers in main.go
darkowlzz Nov 24, 2021
f927c76
Move Artifact conditions to conditions
darkowlzz Nov 24, 2021
34b5dcf
Add gomega matcher for artifact
darkowlzz Nov 25, 2021
45484ef
api: Embed runtime.Object in Source interface
darkowlzz Jan 19, 2022
c3e2087
Add internal packages error and reconcile
darkowlzz Dec 19, 2021
8908d80
Use runtime-events-fixes branch temporarily
darkowlzz Jan 16, 2022
991692f
bucket: Replace GetInterval() with GetRequeueAfter()
darkowlzz Nov 24, 2021
34b27a0
Rewrite `BucketReconciler` to new standards
hiddeco Jul 31, 2021
3105ba9
Consolidate condition types into `FetchFailed`
hiddeco Aug 9, 2021
cf7dca0
BucketReconciler: Add reconcileArtifact tests
darkowlzz Aug 9, 2021
af946e7
Add more reconcileMinioSource test cases
darkowlzz Nov 27, 2021
8dd51ab
Add bucket controller tests for reconcileGCPSource
darkowlzz Nov 29, 2021
4a1818d
bucket: Ignore patch error not found on delete
darkowlzz Dec 8, 2021
a1e5067
bucket: Add more reconciler design improvements
darkowlzz Dec 20, 2021
f73df89
Merge remote-tracking branch 'origin/reconcilers-dev-bucket' into azblob
laozc Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bucket: Replace GetInterval() with GetRequeueAfter() 
Signed-off-by: Sunny <darkowlzz@protonmail.com>
  • Loading branch information
@darkowlzz
darkowlzz committed Dec 7, 2021
commit f1302d8c9c2fa323d711c5a26594014ce4a9b592
4 changes: 2 additions & 2 deletions controllers/bucket_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,10 @@ func (r *BucketReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr

log.Info(fmt.Sprintf("Reconciliation finished in %s, next run in %s",
time.Since(start).String(),
bucket.GetInterval().Duration.String(),
bucket.GetRequeueAfter().String(),
))

return ctrl.Result{RequeueAfter: bucket.GetInterval().Duration}, nil
return ctrl.Result{RequeueAfter: bucket.GetRequeueAfter()}, nil
}

func (r *BucketReconciler) reconcile(ctx context.Context, bucket sourcev1.Bucket) (sourcev1.Bucket, error) {
Expand Down