Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching for GitHub App tokens #871

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Add caching for GitHub App tokens #871

merged 1 commit into from
Mar 1, 2025

Conversation

matheuscscp
Copy link
Member

Builds on #870

@matheuscscp matheuscscp requested a review from a team as a code owner February 23, 2025 15:27
@matheuscscp matheuscscp mentioned this pull request Feb 23, 2025
Merged
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch 2 times, most recently from 392ea00 to 3f9b325 Compare February 23, 2025 16:14
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from 3f9b325 to c1d4547 Compare February 23, 2025 17:26
stefanprodan
stefanprodan reviewed Feb 23, 2025
View reviewed changes
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from c1d4547 to cb213e0 Compare February 23, 2025 18:22
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from cb213e0 to aa6f6dd Compare February 23, 2025 22:45
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from aa6f6dd to f64c61d Compare February 27, 2025 00:07
@matheuscscp matheuscscp force-pushed the token-cache branch 3 times, most recently from 49e912c to a0e0679 Compare February 27, 2025 01:16
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from f64c61d to 3fa33f5 Compare February 27, 2025 01:17
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from 3fa33f5 to ff449bf Compare February 27, 2025 01:30
stefanprodan
stefanprodan approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from token-cache to main March 1, 2025 01:12
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch 2 times, most recently from 250822c to 2121d58 Compare March 1, 2025 01:33
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch 2 times, most recently from c31ba1a to 3383354 Compare March 1, 2025 01:46
@matheuscscp
Add caching for GitHub App tokens
4cd4dbb 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp matheuscscp force-pushed the github-app-token-cache branch from 3383354 to 4cd4dbb Compare March 1, 2025 01:56
@matheuscscp matheuscscp merged commit ff04927 into main Mar 1, 2025
12 checks passed
@matheuscscp matheuscscp deleted the github-app-token-cache branch March 1, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@aryan9600 aryan9600 Awaiting requested review from aryan9600 aryan9600 is a code owner

@hiddeco hiddeco Awaiting requested review from hiddeco hiddeco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan