Verify repository id in git notifiers #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The different git notifiers need repository ids in different formats. On top of that some git providers support repositories in subgroups while others do not support nesting. Each notifier needs test to verify that they support their specific functionality. Signed-off-by: Philip Laine <philip.laine@xenit.se>
ce4cbf3 to
e812068
Compare
stefanprodan
approved these changes
Nov 17, 2020
bigkevmcd
reviewed
Nov 17, 2020
bigkevmcd
reviewed
Nov 17, 2020
Signed-off-by: Philip Laine <philip.laine@xenit.se>
|
@bigkevmcd Thanks for the tips out error message formatting! Is it right now? @stefanprodan Should be ready to merge. Yep hopefully finding errors in the git url will be easier now. |
Signed-off-by: Philip Laine <philip.laine@xenit.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The different git notifiers need repository ids in different formats.
On top of that some git providers support repositories in subgroups
while others do not support nesting. Each notifier needs test to verify
that they support their specific functionality.