-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DataDog notification provider #592
feat: add DataDog notification provider #592
Conversation
b982abb
to
21efe48
Compare
Please use |
c7a70ae
to
0cef615
Compare
Thanks for the review @stefanprodan. I made the changes that you requested. I'm setting |
Okay, I think that make sense. I've removed the code that derives |
55f9bd8
to
b2e0e9c
Compare
Thanks for this change! We use datadog and this will be very helpful. |
2d46239
to
fddf96b
Compare
@mrparkers can you please squash the commits and rebase with upstream main. |
fddf96b
to
f1d8d74
Compare
Done! Thanks again for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2f69169
to
af15854
Compare
Hi @stefanprodan, I just rebased with main again. Let me know if there's anything else you need from me 😄 |
@mrparkers can you please run |
af15854
to
b075a5f
Compare
@stefanprodan Done! |
b075a5f
to
5116ae5
Compare
5116ae5
to
2b4a99e
Compare
Signed-off-by: Michael Parker <michael@parker.gg>
2b4a99e
to
71ed90e
Compare
This PR adds support for DataDog as a notification provider.
This provider publishes events that look like this:
...given a provider config that looks like this:
...and a secret that looks like this:
...and an alert that looks like this:
I made a few assumptions along the way based on the way other events / tags look within the DataDog ecosystem. I tried to leave comments in the code that explains the rationale behind each of these.