Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor reconcilers and introduce v1beta2 API #435
Refactor reconcilers and introduce v1beta2 API #435
Changes from all commits
974a77d
9f2d0e1
8dadcac
a9ac01a
ab92536
ab5cdc8
613111c
5fd17e6
2b35ef5
ae65712
ee2600a
caec764
012faa2
70c678f
1a4a4a8
c9a774f
d16588a
5a0d6dd
4aad301
831785a
04f5288
78fe519
20fa1a0
ef94247
b0c02d7
16012ce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add or update the sample CRDs in config/samples for these new APIs. They are useful for quickly referring to samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left them on v1beta1 to test the API upgrade hooks, I'll update them to v1beta2 once we're close to the finish line with this PR.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.