-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the webex notification provider and markdown #352
Conversation
Signed-off-by: ahothan <ahothan@cisco.com>
Thank you for this, if you are looking to add an example webex notification provider, the file where provider-specific examples are drawn from is: The example would land in the fluxcd docs under here: (The current supplementary docs from each controller repo are pulled into the fluxcd/website repo on each deploy) |
17ae4d8
to
eda9199
Compare
documentation done |
checking if this markdown format would be better:
|
@ahothan can you please post a print screen of how it looks now? |
@stefanprodan In this snapshot, the Alert summary was set to "cc-k8s cluster notification" for the first 2, Please provide any suggestion... |
not sure what to make of this error in the "kind" job: Run kubectl -n notification-system get providers -oyaml |
The e2e tests are filing because your code is not properly formatted, see the first failing step in CI. To fix this, run |
This would make Webex different from all the others and I'm not for diverging from all the other providers. |
Signed-off-by: ahothan <ahothan@cisco.com>
@stefanprodan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ahothan 🥇
Signed-off-by: ahothan ahothan@cisco.com
I have tested this against the latest webex API portal and verified I could get notifications in the targeted webex space.
Requires 2 additional parameters to make it work: a room ID and a Webex bot access token (both can be retrieved using the
webex developer web site after registering).
I have also enhanced the formatted markdown.
Example of webex space output: