-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grafana annotations API #322
Conversation
Create Grafana provider and alert apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Provider
metadata:
name: grafana
namespace: flux-system
spec:
type: grafana
address: http://grafana.istio-system.svc.cluster.local/api/annotations
---
apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Alert
metadata:
name: test-grafana
namespace: flux-system
spec:
providerRef:
name: grafana
eventSeverity: info
eventSources:
- kind: GitRepository
name: '*'
- kind: Kustomization
name: '*'
- kind: HelmRelease
name: '*' how to enable annotations on a dashboardGrafana dashboard settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fsequeira1 thanks for your contribution. Can you please rebase with main and add grafana
to the API docs provider table and also add an example in the alerts docs. The docs are here: https://github.com/fluxcd/notification-controller/tree/main/docs/spec/v1beta1
30cc35c
to
687a59e
Compare
Hello @stefanprodan. can you please confirm if it is ok now? |
@fsequeira1 please rebase with upstream main and signoff your commits. |
687a59e
to
2d05ef9
Compare
@fsequeira1 this looks great now. Can you squash all commits and force push a single signed commit please. |
Signed-off-by: Filipe Sequeira <filipe@weave.works> Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
c07a0ed
to
659c01f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @fsequeira1 🥇
Great contribution @fsequeira1 ! Look forward to the prometheus provider 👍 |
Related to: fluxcd/flux2#1024
This provider allows sending notifications to Grafana as annotations. To show the annotations on a dashboard there is a default tag (
flux
) that needs to be enabled.Signed-off-by: Filipe Sequeira filipe@weave.works