Custom Git Commit Status Prefix #209
Closed
+45
−141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #194
Problem
When setting a git commit status the controller only uses the
event.InvolvedObject.Kind
andevent.InvolvedObject.Name
to generate the status' context. This does not allow multiple clusters to update the commit status if they use the same Kustomization name.Proposed Solution
The event that is passed to the
formatNameAndDescription
function contains aMetadata
field.The
AlertSpec
contains aSummary
field which is used as aShort description of the impact and affected cluster.
The event handler copies the value of the
Summary
field from theAlertSpec
to theMetadata
field of the event.This PR checks the value of the
Metadata
field to see if there is asummary
key. If the key exists then the summary value will be prepended to the context of the commit status. This will allow the user to set the prefix of the commit status.