Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slack channel optional #208

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Make slack channel optional #208

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df8150d
Return an error when request status code is not 200
somtochiama Jun 7, 2021
fd90d4e
Adds other 200 status code
somtochiama Jun 7, 2021
fb66d68
Better error message
somtochiama Jun 7, 2021
c2d9b1e
Make slack channel optional
somtochiama Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds other 200 status code 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
  • Loading branch information
@somtochiama
somtochiama committed Jun 7, 2021
commit fd90d4ec35d1e2bc1dc9041dc8cda8a6bcf7df53
2 changes: 1 addition & 1 deletion internal/notifier/client.go
View file
Original file line number Diff line number Diff line change
@@ -93,7 +93,7 @@ func postMessage(address, proxy string, certPool *x509.CertPool, payload interfa
return fmt.Errorf("failed to execute request: %w", err)
}

if resp.StatusCode != http.StatusOK {
if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusAccepted && resp.StatusCode != http.StatusCreated {
b, err := ioutil.ReadAll(resp.Body)
if err != nil {
return fmt.Errorf("unable to read response body, %s", err)