-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Mozilla SOPS decryption #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb5ab7
to
30ac80c
Compare
hiddeco
reviewed
Sep 1, 2020
adb6ab4
to
812e83e
Compare
hiddeco
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go to me for now. In a future iteration we should have a look at getting rid of the gpg
binary as we now have full control over the process, and can now make it so that it does not have to fallback.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Mozilla SOPS decryption fix: #94
Example
In order to store secrets safely in a public or private Git repository, you can use Mozilla SOPS and encrypt your Kubernetes Secrets data with OpenPGP keys.
Generate a GPG key without passphrase using gnupg then use sops to encrypt a Kubernetes secret:
sops --pgp=FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4 \ --encrypt --encrypted-regex '^(data|stringData)$' --in-place my-secret.yaml
Commit and push the encrypted file to Git.
Create a secret in the
gitops-system
namespace with the OpenPGP private key:gpg --export-secret-keys --armor FBC7B9E2A4F9289AC0C1D4843D16CEE4A27381B4 | kubectl -n gitops-system create secret generic sops-gpg \ --from-file=sops.asc=/dev/stdin
Configure decryption by referring the private key secret: