Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI origin revision to events #1338

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add OCI origin revision to events #1338

merged 1 commit into from
Jan 22, 2025

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Jan 21, 2025 •
edited
Loading

Part of: fluxcd/flux2#5148

I have tested this e2e using GitHub:

oci-bad-commit-status

oci-good-commit-status

matheuscscp
matheuscscp commented Jan 21, 2025
View reviewed changes
Copy link
Member Author

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanprodan Please take a look at the comments 🙏

@matheuscscp matheuscscp marked this pull request as ready for review January 21, 2025 11:01
@matheuscscp matheuscscp force-pushed the origin-revision branch 4 times, most recently from cdd7060 to f586a58 Compare January 21, 2025 16:20
@stefanprodan stefanprodan added the enhancement New feature or request label Jan 21, 2025
@matheuscscp matheuscscp force-pushed the origin-revision branch 2 times, most recently from 75a5b71 to 15dbd9b Compare January 21, 2025 18:04
@matheuscscp
Add OCI revision to events
eccdbad 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@stefanprodan stefanprodan changed the title Add OCI revision to events Add OCI origin revision to events Jan 22, 2025
stefanprodan
stefanprodan approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@matheuscscp matheuscscp merged commit 5967686 into main Jan 22, 2025
6 checks passed
@matheuscscp matheuscscp deleted the origin-revision branch January 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheuscscp @stefanprodan