Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/int: Set exit code 1 on tf destroy failure #462

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

darkowlzz
Copy link
Contributor

Explicitly set the test program exit code to 1 when terraform destroy fails to delete the infrastructure.

This was observed when GKE clusters failed to delete due to delete protection enabled by default in the latest version of terraform provider google.

Verified the same fix in fluxcd/pkg#682 .

Explicitly set the test program exit code to 1 when terraform destroy
fails to delete the infrastructure.

This was observed when GKE clusters failed to delete due to delete
protection enabled by default in the latest version of terraform
provider google.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz added the area/testing Testing related issues and pull requests label Nov 3, 2023
@darkowlzz darkowlzz requested a review from somtochiama November 3, 2023 21:06
@darkowlzz darkowlzz merged commit 7725a45 into main Nov 4, 2023
@darkowlzz darkowlzz deleted the test-int-stop-exit-code branch November 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants