Skip error policy reconciliation if no tags are found #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Aug 8, 2022
|
Test image based on 39cc9bf: |
Merged
|
Test image based on 3826a42: ghcr.io/fluxcd/image-reflector-controller:rc-3826a423 |
stefanprodan
reviewed
Aug 8, 2022
| @@ -180,6 +180,14 @@ func (r *ImagePolicyReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| var tags []string | |||
| tags, err = r.Database.Tags(repo.Status.CanonicalImageName) | |||
| if err == nil { | |||
| if len(tags) == 0 { | |||
| msg := fmt.Sprintf("no tags found in '%s', retrying in %s", repo.Name, repo.Spec.Interval.Duration) | |||
There was a problem hiding this comment.
Maybe we should mention where we didn’t found them?
Suggested change
| msg := fmt.Sprintf("no tags found in '%s', retrying in %s", repo.Name, repo.Spec.Interval.Duration) | |
| msg := fmt.Sprintf("no tags found in local storage for '%s', retrying in %s", repo.Name, repo.Spec.Interval.Duration) |
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At controller restart, it is quite common to experience
Cannot determine latest tag for policy: version list argument cannot be emptyerrors. This happens because the existing repository may be Ready, but all its underlying data has been lost as it resides in the controller.Instead of erroring, this PR tries to self-heal by postponing the Policy reconciliation based on its repository set interval.
As a result, the controller will log:
{"level":"info","ts":"2022-08-08T17:37:52.544Z","logger":"controller.imagepolicy","msg":"no tags found in 'my-image-policy', retrying in 1m0s","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImagePolicy","name":"source-controller","namespace":"flux-system"}And generate a Kubernetes Event with similar information.
Fixes: #299