Enrich early EOF error message
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new make target creates an env file that can be used for debugging purposes. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
3197086 to
7cc4085
Compare
aryan9600
requested changes
Jul 26, 2022
controllers/git_test.go
Outdated
|
|
||
| err = push(context.TODO(), repo.Workdir(), "test", access) | ||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(err.Error()).To(ContainSubstring("early EOF")) |
There was a problem hiding this comment.
Since this test is supposed to test the enrichment of the "early EOF" error messages, it'd make more sense to check for the additional message that we explicitly add.
Comment on lines
890
to
892
| if err.Error() == "early EOF" { | ||
| return fmt.Errorf("early EOF (the SSH key may not have write access to the repository)") | ||
| } |
There was a problem hiding this comment.
maybe this would be better?
Suggested change
| if err.Error() == "early EOF" { | |
| return fmt.Errorf("early EOF (the SSH key may not have write access to the repository)") | |
| } | |
| if strings.Contains(err.Error(), "early EOF") { | |
| return fmt.Errorf("%w (the SSH key may not have write access to the repository)", err) | |
| } |
added 2 commits
July 26, 2022 11:17
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
hiddeco
approved these changes
Jul 26, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Git servers may close the connection abruptly when the user does not have write access to a repository whilst trying to do a push operation. The result for the end users is an
early EOFmessage, which is not very helpful.This PR changes the error message to:
early EOF (the SSH key may not have write access to the repository).Fixes #405.