Statically build using musl toolchain and target alpine #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be updated with source controller once fluxcd/source-controller#558 is merged. |
83aa0e4 to
e6978bb
Compare
relu
approved these changes
Jan 26, 2022
| # - Use read-only bind instead of copying go source files. | ||
| # - Cache go packages. | ||
| RUN --mount=target=. \ | ||
| --mount=type=cache,target=/root/.cache/go-build \ |
There was a problem hiding this comment.
This works fine on localhost but doesn't help much in CI because the build cache is not something you can easily restore. See this issue for context.
There was a problem hiding this comment.
Thank you @relu, I will take a look and check ways to improve it. 👍
10b9850 to
622f3ee
Compare
24 tasks
81e6fbf to
c70ec1d
Compare
added 5 commits
January 28, 2022 09:35
This aligns with the final image used by source controller. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
LGTM
Thanks @pjbgf 🏅
I've tested this on several EKS ARM64 clusters where the previous release was failing 90% of the time with ✗ ImageUpdateAutomation reconciliation failed: 'unable to clone: SSH could not read data: Error waiting on socket'. After using a build from this PR all errors were gone 🎉
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
alpineas final base image.make verify.Although the controller is statically built, we are targeting
alpineto help users debugging the image if they so need/wish.