Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-arch buildx docker images #67

Closed
wants to merge 1 commit into from
Closed

Support multi-arch buildx docker images #67

wants to merge 1 commit into from

Conversation

xunholy
Copy link
Member

@xunholy xunholy commented Sep 4, 2020

Signed-off-by: Michael Fornaro 20387402+xUnholy@users.noreply.github.com

Description

  • Updating Dockerfile to ensure the go binary is compiled for the target architecture platform.
  • Adding a test workflow for pushing a release -multi-arch suffix image that doesn't break the existing AMD64 image variant.

TODO

  • Discuss other resources that need to be multi-arch in Fluxv2
  • Phase -multi-arch variant to replace existing.

**EDIT: Just noticed #68 which I think we can slightly improve to use buildx and tweak the Dockerfile to accommodate additional architectures in the future on top of arm/amd

Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com>
@stefanprodan
Copy link
Member

@xunholy we are moving away from Docker Hub. See fluxcd/flux2#194

@stefanprodan
Copy link
Member

In #68 we use the new Docker action that's based on QEMU and Docker buildx. GHCR doesn't support multi-arch so we have created an arm64 image. We have no plans to support other arches besides amd64/arm64.

@xunholy
Copy link
Member Author

xunholy commented Sep 4, 2020

@stefanprodan any idea when GHCR roadmap includes multi-arch support?

quay also supports multi-arch images and doesn't impose the limit restrictions that docker hub has introduced.

In either regard, I can update this PR to move to GHCR using the QEMU and Docker buildx approach, or shall we close this and just let the PR you raised minutes after move forward? Perfect timing really!

@stefanprodan
Copy link
Member

We had Flux on Quay and they banned us for to many pulls, Flux is close to 50M pulls per year, I'm not considering going back to Quay like ever lol. Yes please close this PR.

@xunholy
Copy link
Member Author

xunholy commented Sep 4, 2020

Closing this PR and will consider reopening a PR when GHCR supposes multi arch images.

The Dockerfile changes could also be considered as overall improvements, even though only reducing layers in the build stage still good practice.

@xunholy xunholy closed this Sep 4, 2020
@xunholy
Copy link
Member Author

xunholy commented Sep 16, 2020

@stefanprodan GHCR does not support multi-arch, this would be a good feature to investigate as it means there would be no need for the --arch CLI command and it will pull the corresponding image natively, especially nice that there is no need to append image names with arch EG. -arm64 or -amd64.

@stefanprodan
Copy link
Member

We want to track downloads of amd64 and arm64 separately so the current registry setup will not change anytime soon.

jtyr pushed a commit to jtyr/fluxcd-helm-controller that referenced this pull request Dec 14, 2023
correct self-referential go import paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants