Download and use controller-gen and envtest locally

[cebernardi]

If we download the project in a local environment with no kubebuilder and kubebuilder-tools, or with an outdated version of controller-gen, executing make test will fail (see also this comment).

This PR copies the approach of latest version of kubebuilder, downloading the executables in a local directory and consuming them from there.

(since apparently there's no release for envtest, I had to use latest)

Signed-off-by: Cecilia Bernardi cbernardi@expediagroup.com

[stefanprodan]

I used a different approach in kustomize-controller where envtest is not used from the shared dir. I would like to get this in all Flux controllers, please see https://github.com/fluxcd/kustomize-controller/blob/main/Makefile

[cebernardi]

@stefanprodan thank you for the feedback!
I'm adapting this PR to your suggestions.

[cebernardi]

@stefanprodan I modified the PR following your comment.

However, there are some differences from the Makefile you linked, the main ones being that both controller-gen and envtest are downloaded in a local folder (bin). This was copied by the latest kubebuilder approach.

What are your thoughts on the proposed changes?

[stefanprodan]

@cebernardi this looks great, please squash all commits into a single one.

[cebernardi]

@stefanprodan please ignore my last commit, it's a rebase fail :(
still working on it

[cebernardi]

@stefanprodan all the commits are now squashed

[stefanprodan]

This fails for me on Apple Silicon and Go 1.17:

go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20211208212546-f236f0345ad2
go get: installing executables with 'go get' in module mode is deprecated.
	To adjust and download dependencies of the current module, use 'go get -d'.
	To install using requirements of the current module, use 'go install'.
	To install ignoring the current module, use 'go install' with a version,
	like 'go install example.com/cmd@latest'.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
go get: added sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20211208212546-f236f0345ad2
mkdir -p /Users/stefanprodan/go/src/github.com/fluxcd/helm-controller/testbin
/Users/stefanprodan/go/src/github.com/fluxcd/helm-controller/bin/setup-envtest use latest --bin-dir=/Users/stefanprodan/go/src/github.com/fluxcd/helm-controller/testbin
unable to find a version that was supported for platform darwin/arm64
make: *** [Makefile:127: install-envtest] Error 2

@hiddeco can you please try this on your Intel machine?

[stefanprodan]

Ok I got this running:

KUBEBUILDER_ASSETS="/Users/stefanprodan/go/src/github.com/fluxcd/helm-controller/testbin/k8s/1.22.1-darwin-amd64" go test ./... -coverprofile cover.out
?   	github.com/fluxcd/helm-controller	[no test files]
ok  	github.com/fluxcd/helm-controller/controllers	12.422s	coverage: 20.5% of statements
?   	github.com/fluxcd/helm-controller/internal/kube	[no test files]
ok  	github.com/fluxcd/helm-controller/internal/runner	0.871s	coverage: 28.1% of statements
ok  	github.com/fluxcd/helm-controller/internal/util	0.190s	coverage: 100.0% of statements

I'll suggest changes.

[stefanprodan]

Please pin envtest to AMD64

[cebernardi]

should I squash again?

[stefanprodan]

Yes please squash

[hiddeco]

I would maybe still make it a configurable flag to ease the first time usage if ARM64 ever becomes available.. E.g. ENVTEST_ARCH?=amd64

[cebernardi]

I would maybe still make it a configurable flag to ease the first time usage if ARM64 ever becomes available.. E.g. ENVTEST_ARCH?=amd64

done

[hiddeco]

This all looks good to me, and a very much welcomed improvement. Thanks a lot @cebernardi
🙇 🥇

[stefanprodan]

LGTM

Thanks @cebernardi