Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install and upgrade applying subchart CRDs when condition is false #1123

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

matheuscscp
Copy link
Member

Fixes #938

Supersedes #941

@matheuscscp matheuscscp marked this pull request as ready for review December 11, 2024 16:22
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🎖️

@matheuscscp
Copy link
Member Author

Will add a test for upgrade tomorrow.

@matheuscscp matheuscscp force-pushed the remove-subchart-crd branch 2 times, most recently from f69d2ff to 667a0f8 Compare December 13, 2024 14:47
@matheuscscp matheuscscp marked this pull request as draft December 13, 2024 14:58
@matheuscscp matheuscscp marked this pull request as ready for review December 13, 2024 14:58
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp matheuscscp merged commit 58d5812 into main Jan 10, 2025
6 checks passed
@matheuscscp matheuscscp deleted the remove-subchart-crd branch January 10, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelmRelease: CRDs of disabled subcharts get installed anyway
3 participants