Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HelmRelease v2 in flux reconcile and flux create #4766

Merged
merged 2 commits into from
May 12, 2024
Merged

Add support for HelmRelease v2 in flux reconcile and flux create #4766

merged 2 commits into from
May 12, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented May 7, 2024 •
edited by stefanprodan
Loading

fixes #4761

@souleb souleb marked this pull request as draft May 7, 2024 09:39
@souleb souleb force-pushed the reconcile-hr-with-chartref branch 2 times, most recently from af4b837 to c34bac3 Compare May 7, 2024 09:41
@stefanprodan stefanprodan mentioned this pull request May 9, 2024
Merged
@souleb souleb force-pushed the reconcile-hr-with-chartref branch 2 times, most recently from aac55b5 to f2e77db Compare May 10, 2024 09:38
@stefanprodan stefanprodan mentioned this pull request May 10, 2024
Merged
@souleb souleb force-pushed the reconcile-hr-with-chartref branch from f2e77db to 68bafa5 Compare May 10, 2024 12:47
@souleb souleb marked this pull request as ready for review May 10, 2024 12:48
@souleb souleb force-pushed the reconcile-hr-with-chartref branch 3 times, most recently from ca7b48d to 125ace7 Compare May 10, 2024 15:36
stefanprodan
stefanprodan reviewed May 10, 2024
View reviewed changes
@souleb
Enable reconciling HelmReleases with ChartRef
0d0285a 
If implemented HR with ChartRef can be reconciled with
`--with-source`set.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the reconcile-hr-with-chartref branch 3 times, most recently from cce80c6 to 354c252 Compare May 11, 2024 20:25
@souleb
Add support for creating HR with .spec.ChartRef
5feee5c 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the reconcile-hr-with-chartref branch from 354c252 to 5feee5c Compare May 11, 2024 20:49
@souleb souleb requested a review from stefanprodan May 12, 2024 13:06
stefanprodan
stefanprodan approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🥇

@stefanprodan stefanprodan changed the title Add support for HelmRelease V2 in flux reconcile and flux create Add support for HelmRelease v2 in flux reconcile and flux create May 12, 2024
@souleb souleb merged commit dd7ef7d into main May 12, 2024
8 checks passed
@souleb souleb deleted the reconcile-hr-with-chartref branch May 12, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for HelmReleases v2 with .spec.chartRef
2 participants
@souleb @stefanprodan