Make tenant isolation paragraph more explicit #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please signoff your commit https://github.com/fluxcd/flux2-multi-tenancy/pull/19/checks?check_run_id=1930941582 |
In its current for the first paragraph in the tenant isolation section might be misunderstood by some users less familiar with k8s and flux2 security model. This change makes wording more explicit to indicate that webhook validation is a hard requirement for tenant isolation. Signed-off-by: Jacek Nykis <jacek@stellar.org>
stefanprodan
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current for the first paragraph in the tenant isolation
section might be misunderstood by some users less familiar with
k8s and flux2 security model.
This change makes wording more explicit to indicate that webhook
validation is a hard requirement for tenant isolation.